-
Notifications
You must be signed in to change notification settings - Fork 307
chore: Adding an optional hdfs crate
#1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b667401
Adding an optional `hdfs` crate
comphead af60b84
Adding an optional `hdfs` crate
comphead 25657d3
Adding an optional `hdfs` crate
comphead 127dc4e
Adding an optional `hdfs` crate
comphead 4e4c7bc
Adding an optional `hdfs` crate
comphead a9e39b2
Merge remote-tracking branch 'upstream/main' into hdfs
comphead c288600
Adding an optional `hdfs` crate
comphead ecc7995
Adding an optional `hdfs` crate
comphead 7ae0910
Update NOTICE.txt
comphead adfacc7
Update NOTICE.txt
comphead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # This is an optional HDFS crate | ||
| # To build it from root is required to provide a valid JAVA_HOME | ||
| # and enable `hdfs` feature | ||
| # Example: JAVA_HOME="/opt/homebrew/opt/openjdk@11" cargo build --features=hdfs | ||
|
|
||
| [package] | ||
| name = "datafusion-comet-objectstore-hdfs" | ||
| description = "Comet HDFS integration" | ||
| version = { workspace = true } | ||
| homepage = { workspace = true } | ||
| repository = { workspace = true } | ||
| authors = { workspace = true } | ||
| readme = { workspace = true } | ||
| license = { workspace = true } | ||
| edition = { workspace = true } | ||
|
|
||
| [features] | ||
| default = ["hdfs", "try_spawn_blocking"] | ||
| hdfs = ["fs-hdfs"] | ||
| hdfs3 = ["fs-hdfs3"] | ||
| # Used for trying to spawn a blocking thread for implementing each object store interface when running in a tokio runtime | ||
| try_spawn_blocking = [] | ||
|
|
||
| [dependencies] | ||
| async-trait = { workspace = true } | ||
| bytes = { workspace = true } | ||
| chrono = { workspace = true } | ||
| fs-hdfs = { version = "^0.1.12", optional = true } | ||
| fs-hdfs3 = { version = "^0.1.12", optional = true } | ||
| futures = { workspace = true } | ||
| object_store = { workspace = true } | ||
| tokio = { version = "1", features = ["macros", "rt", "rt-multi-thread", "sync", "parking_lot"] } | ||
|
|
||
| [package.metadata.cargo-machete] | ||
| ignored = ["fs-hdfs", "fs-hdfs3"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we did not have clang before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we dont' as
fs-hdfsfailed before that it was not able to findlibclang*.sofiles