perf: Only add CopyExec if source of ScanExec is native_comet#1808
Closed
andygrove wants to merge 3 commits intoapache:mainfrom
Closed
perf: Only add CopyExec if source of ScanExec is native_comet#1808andygrove wants to merge 3 commits intoapache:mainfrom
ScanExec is native_comet#1808andygrove wants to merge 3 commits intoapache:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1808 +/- ##
============================================
+ Coverage 56.12% 58.50% +2.37%
- Complexity 976 1129 +153
============================================
Files 119 129 +10
Lines 11743 12582 +839
Branches 2251 2341 +90
============================================
+ Hits 6591 7361 +770
+ Misses 4012 4002 -10
- Partials 1140 1219 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
lgtm so far. (pending ci and changing from draft status)
Member
Author
|
I am running into unexpected memory corruption issues with this PR, so it seems that copies are needed in more cases than I had realized. |
Member
Author
|
I started this PR thinking it would be a trivial change, but I need to learn more about the behavior here and this is not a current priority, so closing the PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1836
Rationale for this change
Avoid adding unnecessary copies. Thanks to @rluvaton for noticing this issue in #1793 (comment)
What changes are included in this PR?
Add a flag to the protobuf definition of
Scanto indicate if the source of the scan reuses buffers.How are these changes tested?
Existing tests.