Skip to content

build: Disable some rounding tests when miri is enabled #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 2 commits into from
Jun 11, 2025
Merged

build: Disable some rounding tests when miri is enabled #1873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfeb417
disable some rounding tests when miri is enabled
andygrove Jun 11, 2025
c9c4e59
typo
andygrove Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions native/spark-expr/src/math_funcs/round.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ mod test {
use datafusion::physical_plan::ColumnarValue;

#[test]
#[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
fn test_round_f32_array() -> Result<()> {
let args = vec![
ColumnarValue::Array(Arc::new(Float32Array::from(vec![
Expand All @@ -167,6 +168,7 @@ mod test {
}

#[test]
#[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
fn test_round_f64_array() -> Result<()> {
let args = vec![
ColumnarValue::Array(Arc::new(Float64Array::from(vec![
Expand All @@ -184,6 +186,7 @@ mod test {
}

#[test]
#[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
fn test_round_f32_scalar() -> Result<()> {
let args = vec![
ColumnarValue::Scalar(ScalarValue::Float32(Some(125.2345))),
Expand All @@ -199,6 +202,7 @@ mod test {
}

#[test]
#[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
fn test_round_f64_scalar() -> Result<()> {
let args = vec![
ColumnarValue::Scalar(ScalarValue::Float64(Some(125.2345))),
Expand Down
Loading