feat: Support hadoop s3a config in native_iceberg_compat#1925
feat: Support hadoop s3a config in native_iceberg_compat#1925parthchandra merged 4 commits intoapache:mainfrom
Conversation
|
@Kontinuation please review if you can. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
============================================
+ Coverage 56.12% 58.85% +2.72%
- Complexity 976 1141 +165
============================================
Files 119 130 +11
Lines 11743 12867 +1124
Branches 2251 2420 +169
============================================
+ Hits 6591 7573 +982
- Misses 4012 4075 +63
- Partials 1140 1219 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kontinuation
left a comment
Kontinuation
left a comment
There was a problem hiding this comment.
I have tested it with AWS S3 and it worked fine
Thank you! I managed to test it with S3 as well. |
| let map = JMap::from_env(env, &map_object)?; | ||
| // Convert to a HashMap | ||
| let mut collected_map = HashMap::new(); | ||
| // let mut iter = map.iter(&mut env)?; |
There was a problem hiding this comment.
can this commented out code be removed?
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @parthchandra
* Support hadoop s3a config in native_iceberg_compat
5 participants
#1817 introduced S3A configuration for the
native_datafusionreader. This PR does the same fornative_iceberg_compatHow are these changes tested?
Existing unit test