chore: Remove obsolete supportedSortType function after Arrow updates#1946
Closed
Ruchir28 wants to merge 1 commit intoapache:mainfrom
Closed
chore: Remove obsolete supportedSortType function after Arrow updates#1946Ruchir28 wants to merge 1 commit intoapache:mainfrom
Ruchir28 wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
============================================
+ Coverage 56.12% 58.40% +2.27%
- Complexity 976 1140 +164
============================================
Files 119 131 +12
Lines 11743 12878 +1135
Branches 2251 2383 +132
============================================
+ Hits 6591 7521 +930
- Misses 4012 4135 +123
- Partials 1140 1222 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
There are 4 failing Spark SQL tests. Here is the first one: |
Member
|
@Ruchir28 I suspect that we can't completely remove |
Member
|
This PR seems inactive, so moving to draft for now |
Member
|
@Ruchir28 do you still plan on working on this or should we close this PR for now? |
Member
|
I will close this PR for now. Feel free to reopen if work resumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1854
Rationale for this change
The supportedSortType function was a fallback mechanism added to avoid Comet errors on complex single column case, as DataFusion SortExec calls arrow's lexsort_to_indices and the function fallbacks to sort_to_indices for single column case. However, sort_to_indices doesn't support all data types, e.g., struct which led to errors , as reported in this issue
However, with recent Arrow updates, these limitations have been resolved by this PR
As a result, the supportedSortType fallback is no longer needed and, in fact, prevents us from taking advantage of the improved native performance. This PR removes the function and its usages, allowing Comet to handle these sorting operations directly.
What changes are included in this PR?
How are these changes tested?
The existing test case been updated. By changing the test assertion from checkSparkAnswer to checkSparkAnswerAndOperator, we now verify that the operation is correctly executed by the Comet native operator, confirming the fallback to Spark is no longer triggered.