Skip to content

chore: Move stringDecode() to CommonStringExprs trait#2111

Merged
mbutrovich merged 1 commit intoapache:mainfrom
peter-toth:1942-fix-stringdecode-follow-up
Aug 11, 2025
Merged

chore: Move stringDecode() to CommonStringExprs trait#2111
mbutrovich merged 1 commit intoapache:mainfrom
peter-toth:1942-fix-stringdecode-follow-up

Conversation

@peter-toth
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Follow-up to #2075.

Rationale for this change

See discussion #2075 (comment).

What changes are included in this PR?

Introduce CommonStringExprs and move stringDecode() to there.

How are these changes tested?

Existing tests.

Copy link
Copy Markdown
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup PR, @peter-toth!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.19%. Comparing base (f09f8af) to head (ce3a782).
⚠️ Report is 1164 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/scala/org/apache/comet/serde/strings.scala 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2111      +/-   ##
============================================
+ Coverage     56.12%   58.19%   +2.06%     
- Complexity      976     1252     +276     
============================================
  Files           119      141      +22     
  Lines         11743    13204    +1461     
  Branches       2251     2360     +109     
============================================
+ Hits           6591     7684    +1093     
- Misses         4012     4289     +277     
- Partials       1140     1231      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbutrovich mbutrovich merged commit 7425f4b into apache:main Aug 11, 2025
92 checks passed
@peter-toth
Copy link
Copy Markdown
Contributor Author

Thanks for the review @mbutrovich !

coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Co-authored-by: Peter Toth <p_toth@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants