Skip to content

ignore: experiment#2184

Closed
andygrove wants to merge 9 commits intoapache:mainfrom
andygrove:auto-scan-no-native-comet
Closed

ignore: experiment#2184
andygrove wants to merge 9 commits intoapache:mainfrom
andygrove:auto-scan-no-native-comet

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Aug 18, 2025

Which issue does this PR close?

Closes #.

Includes changes from #2176

Rationale for this change

I am curious to see the blast radius if we just stopped choosing native_comet scans in auto scan mode (the default).

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.04%. Comparing base (f09f8af) to head (9c9a554).
⚠️ Report is 392 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometScanRule.scala 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2184       +/-   ##
=============================================
- Coverage     56.12%   44.04%   -12.09%     
- Complexity      976     1061       +85     
=============================================
  Files           119      143       +24     
  Lines         11743    13187     +1444     
  Branches       2251     2358      +107     
=============================================
- Hits           6591     5808      -783     
- Misses         4012     6366     +2354     
+ Partials       1140     1013      -127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove closed this Aug 19, 2025
@andygrove andygrove deleted the auto-scan-no-native-comet branch August 19, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants