perf: Improve BroadcastExchangeExec conversion#2417
Merged
mbutrovich merged 1 commit intoapache:mainfrom Sep 18, 2025
Merged
Conversation
d82ffde to
614ee00
Compare
614ee00 to
0222877
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2417 +/- ##
============================================
+ Coverage 56.12% 57.82% +1.69%
- Complexity 976 1400 +424
============================================
Files 119 147 +28
Lines 11743 13469 +1726
Branches 2251 2341 +90
============================================
+ Hits 6591 7788 +1197
- Misses 4012 4448 +436
- Partials 1140 1233 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
approved these changes
Sep 18, 2025
Closed
andygrove
pushed a commit
to andygrove/datafusion-comet
that referenced
this pull request
Sep 30, 2025
mbutrovich
pushed a commit
that referenced
this pull request
Sep 30, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2416.
Rationale for this change
Currently, the
BroadcastExchangeExecparent appliesCometExecRuleagain after conversion, which will traverse all its children again.datafusion-comet/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala
Line 449 in 9cac1af
What changes are included in this PR?
How are these changes tested?
Existing CI