Skip to content

perf: Improve BroadcastExchangeExec conversion#2417

Merged
mbutrovich merged 1 commit intoapache:mainfrom
wForget:broadcast_conversion
Sep 18, 2025
Merged

perf: Improve BroadcastExchangeExec conversion#2417
mbutrovich merged 1 commit intoapache:mainfrom
wForget:broadcast_conversion

Conversation

@wForget
Copy link
Copy Markdown
Member

@wForget wForget commented Sep 18, 2025

Which issue does this PR close?

Closes #2416.

Rationale for this change

Currently, the BroadcastExchangeExec parent applies CometExecRule again after conversion, which will traverse all its children again.

val newPlan = apply(plan.withNewChildren(newChildren))

What changes are included in this PR?

How are these changes tested?

Existing CI

@wForget wForget force-pushed the broadcast_conversion branch from d82ffde to 614ee00 Compare September 18, 2025 06:25
@wForget wForget force-pushed the broadcast_conversion branch from 614ee00 to 0222877 Compare September 18, 2025 06:33
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.82%. Comparing base (f09f8af) to head (0222877).
⚠️ Report is 516 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometExecRule.scala 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2417      +/-   ##
============================================
+ Coverage     56.12%   57.82%   +1.69%     
- Complexity      976     1400     +424     
============================================
  Files           119      147      +28     
  Lines         11743    13469    +1726     
  Branches       2251     2341      +90     
============================================
+ Hits           6591     7788    +1197     
- Misses         4012     4448     +436     
- Partials       1140     1233      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wForget

@mbutrovich mbutrovich merged commit 2274ee5 into apache:main Sep 18, 2025
94 checks passed
@andygrove andygrove mentioned this pull request Sep 19, 2025
andygrove pushed a commit to andygrove/datafusion-comet that referenced this pull request Sep 30, 2025
mbutrovich pushed a commit that referenced this pull request Sep 30, 2025
Co-authored-by: Zhen Wang <643348094@qq.com>
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: BroadcastExchangeExec parent should not transformUp its children after conversion

4 participants