Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
============================================
+ Coverage 56.12% 58.03% +1.91%
- Complexity 976 1401 +425
============================================
Files 119 147 +28
Lines 11743 13465 +1722
Branches 2251 2341 +90
============================================
+ Hits 6591 7815 +1224
- Misses 4012 4417 +405
- Partials 1140 1233 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
commented
Sep 21, 2025
| Struct(fields) => fields | ||
| .iter() | ||
| .all(|f| can_cast_to_string(f.data_type(), options)), | ||
| .all(|f| can_cast_to_string(f.data_type(), _options)), |
Contributor
There was a problem hiding this comment.
Thank you for this. I was working on fixing this clippy warning myself
comphead
commented
Sep 21, 2025
| array.foreach(v => { | ||
| val casted = v.asInstanceOf[lang.Byte] | ||
| listLiteralBuilder.addByteValues(casted.intValue()) | ||
| listLiteralBuilder.addByteValues( |
Contributor
Author
There was a problem hiding this comment.
fixing the test as the build was not running the test suite was totally ignored
andygrove
approved these changes
Sep 21, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
* chore: fix pr_build*.yml * clippy * chore: fix pr_build*.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Currently both CI pipelines
pr_build_linux.ymlandpr_build_macos.ymlfail silently onAnd the CI runs much less tests than expected
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?