Skip to content

fix: Do not push down subquery filters on native_datafusion scan #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Sep 22, 2025
Merged

fix: Do not push down subquery filters on native_datafusion scan #2438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,16 @@ case class CometScanExec(
}

@transient
private lazy val pushedDownFilters = getPushedDownFilters(relation, dataFilters)
private lazy val pushedDownFilters = {
Copy link
Copy Markdown
Contributor

@comphead comphead Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also document it?

Copy link
Copy Markdown
Member Author

@wForget wForget Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should we document it?

val supportedFilters = if (scanImpl == CometConf.SCAN_NATIVE_DATAFUSION) {
// `native_datafusion` scan does not support subquery pushdown filters,
// see: https://github.com/apache/datafusion-comet/issues/2424
dataFilters.filterNot(isDynamicPruningFilter)
} else {
dataFilters
}
getPushedDownFilters(relation, supportedFilters)
}

override lazy val metadata: Map[String, String] =
if (wrapped == null) Map.empty else wrapped.metadata
Expand Down
Loading