fix: [iceberg] additional parquet independent api for iceberg integration#2442
Merged
andygrove merged 1 commit intoapache:mainfrom Sep 23, 2025
Merged
Conversation
Contributor
Author
|
@andygrove please consider this PR also for 0.10.1 |
andygrove
approved these changes
Sep 22, 2025
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2442 +/- ##
============================================
+ Coverage 56.12% 58.05% +1.93%
- Complexity 976 1403 +427
============================================
Files 119 146 +27
Lines 11743 13466 +1723
Branches 2251 2342 +91
============================================
+ Hits 6591 7818 +1227
- Misses 4012 4413 +401
- Partials 1140 1235 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
pushed a commit
to andygrove/datafusion-comet
that referenced
this pull request
Sep 30, 2025
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Which issue does this PR close?
Part of #2079
Rationale for this change
Needed for iceberg integration. Without this API the current PRs to fix shading issues in Iceberg-Comet still hit a method not found error.
What changes are included in this PR?
Adds a new API to Comet's RowGroupReader that does not use ColumnDescriptor (which is a Parquet class)
How are these changes tested?
With a local build of Comet, and corresponding changes in Iceberg. After this all tests pass.