Skip to content

chore: [branch-0.10] [iceberg] additional parquet independent api for iceberg integration (#2442) #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbutrovich merged 1 commit into from
Sep 30, 2025
Merged

chore: [branch-0.10] [iceberg] additional parquet independent api for iceberg integration (#2442) #2499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions common/src/main/java/org/apache/comet/parquet/RowGroupReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import org.apache.parquet.internal.filter2.columnindex.RowRanges;

public class RowGroupReader implements PageReadStore {
private final Map<ColumnDescriptor, PageReader> readers = new HashMap<>();
private final Map<String, PageReader> readers = new HashMap<>();
private final long rowCount;
private final RowRanges rowRanges;
private final long rowIndexOffset;
Expand All @@ -54,7 +54,11 @@ public long getRowCount() {

@Override
public PageReader getPageReader(ColumnDescriptor path) {
final PageReader pageReader = readers.get(path);
return getPageReader(path.getPath());
}

public PageReader getPageReader(String[] path) {
final PageReader pageReader = readers.get(String.join(".", path));
if (pageReader == null) {
throw new IllegalArgumentException(
path + " is not found: " + readers.keySet() + " " + rowCount);
Expand All @@ -73,7 +77,7 @@ public Optional<Long> getRowIndexOffset() {
}

void addColumn(ColumnDescriptor path, ColumnPageReader reader) {
if (readers.put(path, reader) != null) {
if (readers.put(String.join(".", path.getPath()), reader) != null) {
throw new IllegalStateException(path + " was already added");
}
}
Expand Down
Loading