Conversation
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @kazuyukitanimura
viirya
left a comment
There was a problem hiding this comment.
I think the original idea in the ticket is to create different shim for different Spark version instead of using reflection API for all Spark versions?
|
Thanks @andygrove @viirya
That's right. Currently it is |
I think the original idea is to have spark-3.2 and spark-3.3 shims which use reflection API, and spark-3.4 which uses Spark API as it is available. So for the Spark versions which have the API available, its shim layer doesn't need to use reflection. That's what I got from the ticket. I'm not sure if you are going to do that? If so, then it is fine to have this as initial move. |
My focus would be |
advancedxy
left a comment
There was a problem hiding this comment.
LGTM as an initial move
|
Merged. Thanks. |
|
Thank you all! |
Which issue does this PR close?
Closes #140
Rationale for this change
To add Spark 3.5 and 4.0 shims later.
What changes are included in this PR?
This PR moves the shims to spark version specific directories
How are these changes tested?
Existing tests