fix: Expose bucketing information from CometNativeScanExec#3437
Merged
andygrove merged 1 commit intoapache:mainfrom Feb 7, 2026
Merged
fix: Expose bucketing information from CometNativeScanExec#3437andygrove merged 1 commit intoapache:mainfrom
andygrove merged 1 commit intoapache:mainfrom
Conversation
Add CometNativeScanExec pattern matching to BucketedReadSuite and DisableUnnecessaryBucketedScanSuite so that bucketing tests pass when native_datafusion scan mode is active. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mbutrovich
approved these changes
Feb 7, 2026
Contributor
There was a problem hiding this comment.
My brain sometimes has a hard time parsing diffs of diffs, but I think this looks right. Thanks @andygrove! More coverage of CometNativeScan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CometNativeScanExecpattern matching toBucketedReadSuiteandDisableUnnecessaryBucketedScanSuitein all three Spark version diffs (3.4.3, 3.5.8, 4.0.1)IgnoreCometNativeDataFusion(#3319)tags from 7 tests in the 3.5.8 diff that are now expected to passDetails
When
native_datafusionscan mode is active,CometNativeScanExecreplacesFileSourceScanExecin the query plan. The test suites already pattern-match onCometScanExecbut notCometNativeScanExec, causing ~7 bucketed scan tests to fail.Changes in
BucketedReadSuite.scala:getFileScan()— match onCometNativeScanExecgetBucketScan()— match onCometNativeScanExecverify()in bucket coalescing test — match onCometNativeScanExecforoptionalNumCoalescedBucketsChanges in
DisableUnnecessaryBucketedScanSuite.scala:CometNativeScanExeccheckNumBucketedScan()— match onCometNativeScanExecCloses #3319
Test plan
BucketedReadSuiteandDisableUnnecessaryBucketedScanSuitewithENABLE_COMET=trueandnative_datafusionscan mode🤖 Generated with Claude Code