chore: Remove deprecated SCAN_NATIVE_COMET constant and related test code#3671
Merged
andygrove merged 2 commits intoapache:mainfrom Mar 11, 2026
Merged
Conversation
…code Remove the deprecated `CometConf.SCAN_NATIVE_COMET` constant (`native_comet`) and all test code that references it, including the `usingLegacyNativeCometScan` helper. The native_comet scan was deprecated in 0.9.0 and has been superseded by native_iceberg_compat and native_datafusion scan implementations. - Remove `SCAN_NATIVE_COMET` constant and deprecation annotations - Remove `usingLegacyNativeCometScan` helper methods from CometTestBase - Remove `ParquetReadV2Suite` class (all tests were ignored) - Remove 12 ignored/dead tests across 6 test suites - Simplify conditional branches that checked for SCAN_NATIVE_COMET - Remove `assume(usingLegacyNativeCometScan)` guards (always false) - Simplify `if (!usingLegacyNativeCometScan)` blocks (always true)
andygrove
changed the title
mbutrovich
approved these changes
Mar 11, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2186.
Rationale for this change
The
native_cometscan implementation was deprecated in 0.9.0 and has been superseded bynative_iceberg_compatandnative_datafusion. TheSCAN_NATIVE_COMETconstant and all test code referencing it is dead code that adds maintenance burden and confusion.What changes are included in this PR?
CometConf.SCAN_NATIVE_COMETconstant and its deprecation annotationsusingLegacyNativeCometScanhelper methods fromCometTestBaseParquetReadV2Suiteclass (all tests were already ignored)SCAN_NATIVE_COMETSCAN_NATIVE_COMET— these now always take the non-legacy path (e.g.,checkSparkAnswerAndOperatorinstead ofcheckSparkAnswer)assume(usingLegacyNativeCometScan)guards (always false, so those tests never ran)if (!usingLegacyNativeCometScan)blocks (always true)hasUnsignedSmallIntSafetyCheckto remove dead legacy checknative_cometinCometScanExecandUtilsNet result: -820 lines of dead code removed across 17 files.
How are these changes tested?
This is a cleanup of deprecated/dead code. All removed tests were either already
ignored or guarded byassume(usingLegacyNativeCometScan)which always evaluated to false. The remaining test simplifications only remove the else branches that were never executed. Existing CI tests cover the active scan implementations.