-
Notifications
You must be signed in to change notification settings - Fork 307
fix: use UTC for Arrow schema timezone in SparkToColumnar conversions #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andygrove
merged 8 commits into
apache:main
from
andygrove:fix-spark-to-columnar-timezone
Apr 16, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
19196df
fix: use UTC for Arrow schema timezone in CometSparkToColumnarExec an…
andygrove 9e8bb44
test: add SparkToColumnar non-UTC timezone test
andygrove 9514e2c
merge: resolve conflict with apache/main
andygrove c92ec10
Merge remote-tracking branch 'apache/main' into fix-spark-to-columnar…
andygrove 652b0a3
spotless
andygrove 8f4ecd2
update some config docs
andygrove 916542c
Merge branch 'config-descr' into fix-spark-to-columnar-timezone
andygrove 4d4f95b
Revert
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any test which exercise
COMET_CONVERT_FROM_PARQUET_ENABLED,COMET_CONVERT_FROM_JSON_ENABLED, andCOMET_CONVERT_FROM_CSV_ENABLED, since these will no longer be 'experimental' ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are existing tests in
CometExecSuitefor these, but none that test with non-UTC timezones, so I'll add an additional test.