Skip to content

fix: parameterize file count in Native_datafusion metrics test #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 1 commit into from
Apr 3, 2026
Merged

fix: parameterize file count in Native_datafusion metrics test #3896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2210,9 +2210,11 @@ class CometExecSuite extends CometTestBase {
}

test("Native_datafusion reports correct files and bytes scanned") {
val inputFiles = 2

withTempDir { dir =>
val path = new java.io.File(dir, "test_metrics").getAbsolutePath
spark.range(100).repartition(2).write.mode("overwrite").parquet(path)
spark.range(100).repartition(inputFiles).write.mode("overwrite").parquet(path)

withSQLConf(
CometConf.COMET_ENABLED.key -> "true",
Expand All @@ -2236,8 +2238,8 @@ class CometExecSuite extends CometTestBase {

val numFiles = scanNode.metrics("numFiles").value
assert(
numFiles == 2,
s"Expected exactly 2 files to be scanned, but got metrics reporting $numFiles")
numFiles == inputFiles,
s"Expected exactly $inputFiles files to be scanned, but got metrics reporting $numFiles")
}
}
}
Expand Down
Loading