test: unignore passing DPP test, retag remaining failures#4046
Merged
mbutrovich merged 1 commit intoapache:mainfrom Apr 23, 2026
Merged
test: unignore passing DPP test, retag remaining failures#4046mbutrovich merged 1 commit intoapache:mainfrom
mbutrovich merged 1 commit intoapache:mainfrom
Conversation
mbutrovich
approved these changes
Apr 23, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Glad to see more tests running. Thanks for chipping away at these diffs and the bookkeeping issues, @andygrove! I'll try to get them all fixed this week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1839.
Rationale for this change
With recent Comet DPP work, one of the three DPP tests originally tracked by #1839 now passes everywhere. The other two reveal a genuine AQE-on Comet DPP exchange/broadcast reuse bug, now tracked by #4045.
What changes are included in this PR?
In all three Spark version diffs (3.4.3, 3.5.8, 4.0.1):
avoid reordering broadcast join keys to match input hash partitioning.SPARK-32509: ... canonicalization and exchange reuseandSPARK-34637: DPP side broadcast query stage is created firstlyfrom [Spark SQL] Enable all tests in DynamicPartitionPruningSuite #1839 → Comet DPP exchange/broadcast reuse fails under AQE #4045.How are these changes tested?
Verified on Spark 4.0.1 and 3.5.8 with
ENABLE_COMET=true ENABLE_COMET_ONHEAP=true COMET_PARQUET_SCAN_IMPL=autoagainstDynamicPartitionPruning{V1,V2,V2Filter}Suite{AEOn,AEOff}: the unignored test passes in all six suite variants; the retagged tests still fail with the patterns described in #4045.