-
Notifications
You must be signed in to change notification settings - Fork 307
test: demonstrate INT96 read as TimestampNTZ correctness issue #4154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andygrove
wants to merge
1
commit into
apache:main
Choose a base branch
from
andygrove:tests/issue-3720-int96-ntz-correctness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
82 changes: 82 additions & 0 deletions
82
spark/src/test/scala/org/apache/comet/parquet/ParquetInt96NtzCorrectnessSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.comet.parquet | ||
|
|
||
| import java.sql.Timestamp | ||
| import java.time.LocalDateTime | ||
|
|
||
| import org.apache.spark.SparkException | ||
| import org.apache.spark.sql.CometTestBase | ||
| import org.apache.spark.sql.internal.SQLConf | ||
|
|
||
| import org.apache.comet.CometConf | ||
|
|
||
| /** | ||
| * Demonstrates the correctness issue tracked in | ||
| * https://github.com/apache/datafusion-comet/issues/3720: when a Parquet file stores timestamps | ||
| * as INT96 (Spark's TimestampType, UTC-adjusted local-time semantics) and the read schema | ||
| * requests TimestampNTZ, the `native_datafusion` scan silently returns wall-clock values that | ||
| * disagree with what was written. Spark itself raises (SPARK-36182) to prevent the silent | ||
| * reinterpretation. | ||
| */ | ||
| class ParquetInt96NtzCorrectnessSuite extends CometTestBase { | ||
| import testImplicits._ | ||
|
|
||
| test("INT96 TimestampType read as TimestampNTZ silently returns wrong values") { | ||
| val sessionTz = "America/Los_Angeles" | ||
| val written = "2020-01-01 12:00:00" | ||
|
|
||
| withSQLConf( | ||
| SQLConf.SESSION_LOCAL_TIMEZONE.key -> sessionTz, | ||
| SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key -> "INT96", | ||
| SQLConf.USE_V1_SOURCE_LIST.key -> "parquet") { | ||
| withTempPath { dir => | ||
| val path = dir.getCanonicalPath | ||
|
|
||
| // Write "2020-01-01 12:00:00" America/Los_Angeles as INT96. The bits encode | ||
| // the UTC instant 2020-01-01 20:00:00; reading back as TimestampType applies | ||
| // session-TZ adjustment to recover the original local wall-clock value. | ||
| Seq(Timestamp.valueOf(written)).toDF("ts").write.parquet(path) | ||
|
|
||
| // Reference behavior: Spark refuses to read INT96 as TimestampNTZ | ||
| // (SPARK-36182) because it cannot safely reinterpret an LTZ instant as NTZ. | ||
| withSQLConf(CometConf.COMET_ENABLED.key -> "false") { | ||
| intercept[SparkException] { | ||
| spark.read.schema("ts timestamp_ntz").parquet(path).collect() | ||
| } | ||
| } | ||
|
|
||
| // native_datafusion does not refuse; it silently returns a value that | ||
| // disagrees with the wall-clock value originally written. This is the | ||
| // correctness issue the safety-check fallback is intended to prevent. | ||
| withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_DATAFUSION) { | ||
| val rows = spark.read.schema("ts timestamp_ntz").parquet(path).collect() | ||
| assert(rows.length == 1) | ||
| val actual = rows.head.getAs[LocalDateTime](0) | ||
| assert( | ||
| actual != LocalDateTime.parse("2020-01-01T12:00:00"), | ||
| s"native_datafusion returned the original wall-clock value $actual; " + | ||
| s"expected a silently-shifted value demonstrating the LTZ->NTZ " + | ||
| s"correctness divergence (issue #3720 / SPARK-36182).") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove . It looks like the strings on lines 75-76 have an s prefix but don't contain any variables.