fix: prevent native sort crash for Struct(Map(...)) keys#4157
Open
0lai0 wants to merge 1 commit intoapache:mainfrom
Open
fix: prevent native sort crash for Struct(Map(...)) keys#41570lai0 wants to merge 1 commit intoapache:mainfrom
0lai0 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4123
Rationale for this change
Spark 4.1.1 SQL coverage exposed a case where Comet allows native aggregation for grouping keys that contain nested
MapType(for exampleStructType(MapType(...))).Although planning succeeds, downstream native sort/row-format handling does not support this shape, so the query fails at execution time instead of falling back to Spark during planning.
This PR makes aggregate planning reject map-containing grouping key types so these queries reliably fall back to Spark.
What changes are included in this PR?
containsMapTypehelper inCometBaseAggregateMapTypedirectly or nested inStructType/ArrayTypeCometAggregateSuitefor grouping onStruct(Map(...))CometAggregateSuitefor grouping onArray(Map(...))How are these changes tested?
./mvnw test -Pspark-4.1 -Dtest=none -Dsuites="org.apache.comet.exec.CometAggregateSuite grouping on struct containing map should fallback to Spark"./mvnw test -Pspark-4.1 -Dtest=none -Dsuites="org.apache.comet.exec.CometAggregateSuite group by array of map falls back to Spark (issue #4123)"./mvnw test -Pspark-4.1 -Dtest=none -Dsuites="org.apache.comet.exec.CometAggregateSuite"