docs: add implement-comet-expression Claude skill#4158
Open
andygrove wants to merge 3 commits intoapache:mainfrom
Open
docs: add implement-comet-expression Claude skill#4158andygrove wants to merge 3 commits intoapache:mainfrom
andygrove wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We already ship two Comet-specific Claude skills under
.claude/skills/:audit-comet-expressionfor auditing existing expressions andreview-comet-prfor reviewing PRs. There is no companion skill for the most common contributor task, which is implementing a brand new expression. This PR adds one.The skill is intentionally a thin wrapper around
docs/source/contributor-guide/adding_a_new_expression.mdrather than a duplicate. It encodes the workflow conventions that are not captured in the contributor guide on their own:masterfirst via a shallow clone, so the canonical behavior comes from upstream rather than from whichever Spark version the contributor happens to have checked out.audit-comet-expressionskill against the initial implementation to drive a structured test-coverage iteration loop.What changes are included in this PR?
Adds
.claude/skills/implement-comet-expression/SKILL.md, a short skill that:masterand locating the expression class and tests.scalarFunctionExprToProtoWithReturnType, native scalar function, initial Comet SQL Test).audit-comet-expressionfor gap analysis.make formatandcargo clippychecks.How are these changes tested?
This is a documentation-only change, so no automated tests are added. The skill was reviewed for accuracy against the current contributor guide and the behavior of the existing
audit-comet-expressionskill.