fix: CometReader.loadVector should not overwrite dictionary ids#476
Merged
viirya merged 2 commits intoapache:mainfrom May 28, 2024
Merged
fix: CometReader.loadVector should not overwrite dictionary ids#476viirya merged 2 commits intoapache:mainfrom
viirya merged 2 commits intoapache:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
============================================
- Coverage 34.05% 34.03% -0.02%
Complexity 859 859
============================================
Files 116 117 +1
Lines 38680 38696 +16
Branches 8568 8567 -1
============================================
Hits 13171 13171
- Misses 22746 22762 +16
Partials 2763 2763 ☔ View full report in Codecov by Sentry. |
Member
Author
andygrove
approved these changes
May 27, 2024
sunchao
reviewed
May 27, 2024
Member
Author
|
|
viirya
force-pushed
the
fix_dictionary_array_import
branch
from
c5e4f91 to
4678304
Compare
viirya
force-pushed
the
fix_dictionary_array_import
branch
from
4678304 to
0bc4933
Compare
Member
Author
|
@sunchao Any more comments? Thanks. |
Member
Author
|
Merged. Thanks @andygrove @sunchao |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #475.
Rationale for this change
What changes are included in this PR?
How are these changes tested?