Skip to content

fix: Reuse previous CometDictionary Java arrays#489

Merged
viirya merged 1 commit intoapache:mainfrom
viirya:reuse_copied_dict_values
May 28, 2024
Merged

fix: Reuse previous CometDictionary Java arrays#489
viirya merged 1 commit intoapache:mainfrom
viirya:reuse_copied_dict_values

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented May 28, 2024

Which issue does this PR close?

Closes #488.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

Copy link
Copy Markdown
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

@viirya
Copy link
Copy Markdown
Member Author

viirya commented May 28, 2024

cc @andygrove too

@viirya
Copy link
Copy Markdown
Member Author

viirya commented May 28, 2024

Thank you @kazuyukitanimura

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@viirya viirya merged commit ee15460 into apache:main May 28, 2024
@viirya
Copy link
Copy Markdown
Member Author

viirya commented May 28, 2024

Merged. Thanks @andygrove @kazuyukitanimura

@viirya viirya deleted the reuse_copied_dict_values branch May 28, 2024 20:50
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
* update plans

* update plans

* fix test failure

* Revert debug logging

---------

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reuse previous CometDictionary Java arrays

3 participants