feat: Add experimental support for Apache Spark 3.5.1#587
Merged
andygrove merged 28 commits intoapache:mainfrom Jun 20, 2024
Merged
feat: Add experimental support for Apache Spark 3.5.1#587andygrove merged 28 commits intoapache:mainfrom
andygrove merged 28 commits intoapache:mainfrom
Conversation
This was referenced Jun 18, 2024
Closed
Contributor
Member
Author
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala
Outdated
Show resolved
Hide resolved
common/src/main/spark-3.5/org/apache/comet/shims/ShimBatchReader.scala
Outdated
Show resolved
Hide resolved
common/src/main/spark-3.3/org/apache/comet/shims/ShimBatchReader.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the review @kazuyukitanimura |
advancedxy
reviewed
Jun 20, 2024
| <additional.pre35.test.source>spark-pre-3.5</additional.pre35.test.source> | ||
| <shims.majorVerSrc>spark-3.x</shims.majorVerSrc> | ||
| <shims.minorVerSrc>spark-3.4</shims.minorVerSrc> | ||
| <shims.pre35Src>spark-pre-3.5</shims.pre35Src> |
Contributor
There was a problem hiding this comment.
shims.pre35Src and additional.pre35.test.source seems a bit cumbersome consider there's already shims.majorVerSec and shims.minorVerSrc.
Do you think we should reuse the existing properties instead introducing a new one? If so, I could help submit a pr to address that since this PR is already merged.
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* add profile * fix for LegacyBehaviorPolicy * fix 3.5 ShimCometScanExec * builds with Spark 3.5 * fix builds * use correct parquet version * make docs more explicit * bug fix * remove use of reflection * fix * fix 4.0 build * allow different stability plans for 3.5 * copy approved plans from 3.x to 3.5 * regenerate golden files for 3.5 * enable CI test * fix merge conflict * remove unused imports * Refine shim * remove some uses of reflection * refine shim * remove unused code * remove unused imports * add isTimestampNTZType to 3.5 shim * address feedback * remove unused imports * address feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #541
Rationale for this change
Spark 3.5 is the latest Spark version. Comet will have a larger audience if we support the latest version.
What changes are included in this PR?
This PR adds support for 3.5 with the Comet tests passing but does not add the Spark SQL tests yet. That will be in a separate PR.
Documentation is updated to make it clear that Spark 3.5 support is experimental.
Golden files were copied from pre 3.5 and then regenerated. Commit 96f3e85 shows the differences between pre 3.5 and 3.5 golden files.
How are these changes tested?
Existing tests.