Skip to content

fix: Fallback to Spark for window expression with range frame#719

Merged
viirya merged 2 commits intoapache:mainfrom
viirya:fix_windowframe
Jul 25, 2024
Merged

fix: Fallback to Spark for window expression with range frame#719
viirya merged 2 commits intoapache:mainfrom
viirya:fix_windowframe

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented Jul 24, 2024

Which issue does this PR close?

Closes #720.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya changed the title fix: Disable unsupported window frame type fix: Fallback to Spark for window expression with range frame Jul 24, 2024
Copy link
Copy Markdown
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this problem @viirya

@viirya viirya merged commit f682d5b into apache:main Jul 25, 2024
@viirya
Copy link
Copy Markdown
Member Author

viirya commented Jul 25, 2024

Thanks @huaxingao

@viirya viirya deleted the fix_windowframe branch July 25, 2024 04:08
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
…#719)

* fix: Disable unsupported window frame type

* Fix test

(cherry picked from commit f682d5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comet query with range frame will fail

2 participants