Skip to content

fix: Fallback to Spark when shuffling on struct with duplicate field name#776

Merged
viirya merged 1 commit intoapache:mainfrom
viirya:fix_struct_shuffle
Aug 5, 2024
Merged

fix: Fallback to Spark when shuffling on struct with duplicate field name#776
viirya merged 1 commit intoapache:mainfrom
viirya:fix_struct_shuffle

Conversation

@viirya
Copy link
Copy Markdown
Member

@viirya viirya commented Aug 4, 2024

Which issue does this PR close?

Closes #777.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya
Copy link
Copy Markdown
Member Author

viirya commented Aug 4, 2024

Thanks @andygrove

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.81%. Comparing base (ffb96c3) to head (e40e94d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #776      +/-   ##
============================================
+ Coverage     33.68%   33.81%   +0.13%     
- Complexity      822      879      +57     
============================================
  Files           111      112       +1     
  Lines         42671    42778     +107     
  Branches       9403     9438      +35     
============================================
+ Hits          14372    14467      +95     
- Misses        25325    25350      +25     
+ Partials       2974     2961      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya viirya merged commit 9203f17 into apache:main Aug 5, 2024
@viirya viirya deleted the fix_struct_shuffle branch August 5, 2024 00:43
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java Arrow stream reader cannot read struct vector with duplicate field name

3 participants