feat: Add support for null literal with struct type#797
Merged
andygrove merged 1 commit intoapache:mainfrom Aug 9, 2024
Merged
feat: Add support for null literal with struct type#797andygrove merged 1 commit intoapache:mainfrom
andygrove merged 1 commit intoapache:mainfrom
Conversation
eejbyfeldt
changed the title
kazuyukitanimura
approved these changes
Aug 8, 2024
viirya
approved these changes
Aug 8, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
(cherry picked from commit 1374f2a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #796.
Rationale for this change
Support null literals in more cases. Useful for creating test cases in #735 but probably will come in useful in more cases in the future.
What changes are included in this PR?
Add support for null literals with struct data type.
How are these changes tested?
New test case.