fix: Normalize NaN and zeros for floating number comparison#953
Merged
viirya merged 5 commits intoapache:mainfrom Sep 22, 2024
Merged
fix: Normalize NaN and zeros for floating number comparison#953viirya merged 5 commits intoapache:mainfrom
viirya merged 5 commits intoapache:mainfrom
Conversation
Contributor
|
Related #585 |
Member
|
@viirya Should there be any update to the documentation, such as the compatibility guide as part of this PR? |
Member
Author
Good suggestion. Let me add one. |
Member
Author
|
Thanks @andygrove |
This was referenced Sep 23, 2024
kazuyukitanimura
added a commit
that referenced
this pull request
Sep 27, 2024
## Rationale for this change This is a followup PR of #953 ## What changes are included in this PR? Updated the template, otherwise `make release` will wipe it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #663.
Rationale for this change
What changes are included in this PR?
How are these changes tested?