Skip to content

Conversation

@timsaucer
Copy link
Member

Which issue does this PR close?

Closes #667.

Rationale for this change

The bug report was not an actual bug, but rather a lack of documentation about how to perform the boolean operations on expressions. This change adds in a new page to the documentation that describes a few basics of working with expressions for new users.

What changes are included in this PR?

This change adds a page under Basic Operations called Expressions and details some basics of creating expressions and performing boolean operations.

Are there any user-facing changes?

Only documentation is changed.

Copy link
Contributor

@Michael-J-Ward Michael-J-Ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation! Thank you @timsaucer. LGTM pending Clippy fix to pass CI checks.

@Michael-J-Ward
Copy link
Contributor

@andygrove - those clippy lints are fixed in #669

specifically:

8414157

@timsaucer
Copy link
Member Author

As soon as that other PR goes in, I'll rebase this branch. It should be trivial.

@timsaucer
Copy link
Member Author

@andygrove Checks passed, should be ready to merge.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timsaucer

@andygrove andygrove merged commit 7fd0c96 into apache:main May 9, 2024
@timsaucer timsaucer deleted the tsaucer/expr_bool_documentation branch August 1, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean operators in expressions are ignored

3 participants