Skip to content

Comet 0.9.0#78

Merged
andygrove merged 8 commits intomainfrom
site/comet-0.9.0
Jul 4, 2025
Merged

Comet 0.9.0#78
andygrove merged 8 commits intomainfrom
site/comet-0.9.0

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Jul 1, 2025

@andygrove andygrove marked this pull request as draft July 1, 2025 13:52

### Complex Type Support in Parquet Scans

Comet now supports complex types (Structs, Maps, and Arrays) when reading Parquet files. This functionality is not
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we clarify it is available through native_datafusion reader?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comphead users no longer have to choose the implementation. The 'auto' mode will use the best scan option given the schema.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to clarify this in this PR to update the documentation - apache/datafusion-comet#1981

Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @andygrove
Nice release notes, can't say any better

Copy link
Copy Markdown

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

<table>
<thead>
<tr>
<th>Module</th>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering what Module means here...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the header for the column containing values core-1, core-2, etc


### Improved Spark SQL Test Coverage

Comet now passes 97% of the Spark SQL test suite, with more than 24,000 tests passing (based on testing against
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this 97% considering tests we legitimately skip?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 97% of all tests

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make sure we do not give an impression that we have 3% of incompatibility. Many of them are legitimately skipped because simply it does not apply for Comet.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next sentence was intended to address this:

The remaining ignored tests are mostly related to metric differences or tests irrelevant to
Comet, such as tests for whole-stage code generation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rewritten this section to clarify that the remaining 3% of tests are not ignored due to compatibility issues.

@andygrove
Copy link
Copy Markdown
Member Author

Thanks for the reviews @kazuyukitanimura @parthchandra @comphead.

I'll plan on merging this tomorrow once the release vote passes.

@andygrove andygrove marked this pull request as ready for review July 4, 2025 17:06
@andygrove andygrove merged commit fccabe9 into main Jul 4, 2025
1 check passed
@andygrove andygrove deleted the site/comet-0.9.0 branch July 4, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants