-
Notifications
You must be signed in to change notification settings - Fork 680
Support FILTER in over clause
#1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ada270 to
c8cf584
Compare
Pull Request Test Coverage Report for Build 6564024257
💛 - Coveralls |
c8cf584 to
64c232e
Compare
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lovasoa -- I have a few suggestions and comments, but I also think we can merge this PR as is
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
@alamb : thanks for the review, I addressed your comments. We can see about removing |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lovasoa -- I still thing something is confused here as I don't think SQL supports things like select foo FILTER(where x > 5) FROM t which I think this PR does allow.
However I think this is a reasonable improvement
It would be great to sort out the naming of Dialect::supports_filter_during_aggregation as that now also controls filter during any function
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
support FILTER clause in window functions
fixes #1006