Skip to content

Conversation

@Jefffrey
Copy link
Contributor

Regenerated from this PR: apache/datafusion#17255

@Jefffrey Jefffrey marked this pull request as ready for review August 20, 2025 06:41
@Jefffrey Jefffrey marked this pull request as draft August 20, 2025 08:44
@Jefffrey
Copy link
Contributor Author

Jefffrey commented Aug 20, 2025

Error still persisting so looking into implementation to see what I missed

apache/datafusion#17255 (comment)

Edit: fixed with latest update

@Jefffrey Jefffrey marked this pull request as ready for review August 20, 2025 09:45
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at a few pages of diffs here, but I don't really know how to usefully verify all the output. However, it seems like an improvement to me (and net new functionality, so no regressions) so let's :shipit:

@alamb alamb merged commit f72ac40 into apache:main Aug 23, 2025
@Jefffrey Jefffrey deleted the avg_distinct_float branch August 23, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants