Do some pre-check when building LogicalPlan

[doki23]

Actually, it's not a functionality bug. It's my confusion about the unit test: logical_plan::builder::tests::plan_using_join_wildcard_projection

The following is some code in the test.

let plan = LogicalPlanBuilder::scan_empty(Some("t1"), &employee_schema(), None)?
            .join_using(&t2, JoinType::Inner, vec!["id"])?
            .project(vec![Expr::Wildcard])? // my question about here
            .build()?;

I find some error descriptions in other place of sql planner like:

Expr::Wildcard { .. } => Err(DataFusionError::Internal(
            "Wildcard expressions are not valid in a logical query plan".to_owned(),
        ))

And in the sql planner, we always expand the wildcard before generating a logical plan.
So the unit test may be wrong, please correct me if I am wrong.

We should do some pre-check for building LogicalPlan to expose errors earlier.
For example, SELECT id, first_name, last_name FROM person WHERE NOT id

[doki23]

@houqp @xudong963 PTAL

[alamb]

FWIW I would expect this code:

let plan = LogicalPlanBuilder::scan_empty(Some("t1"), &employee_schema(), None)?
            .join_using(&t2, JoinType::Inner, vec!["id"])?
            .project(vec![Expr::Wildcard])? // my question about here
            .build()?;

To generate a DataFusionError with "Wildcard expressions are not valid in a logical query plan"

[doki23]

As discussion #2012 (comment) , it's necessary to support wildcard in dataframe api. So there's no problem in the code quoted by the issue. I'm going to change this issue to an enhancement that we should do some pre-check for building LogicalPlan.
Of course, when we finish building the LogicalPlan, there's no wildcard expression in the plan.