Skip to content

filter_push_down panics on semi/anti join with join filters #2888

@andygrove

Description

@andygrove

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Since merging ae6dab0 we support join filters on semi/anti joins, although this won't be exposed to end-users until #2885 is merged.

The following code is not correct:

            // Semi/Anti joins can not have join filter.
            JoinType::Semi | JoinType::Anti => unreachable!(
                "on_lr_is_preserved cannot be appplied to SEMI/ANTI-JOIN nodes"
            ),

Describe the solution you'd like
Not sure what the solution is but we shouldn't panic.

Describe alternatives you've considered
None

Additional context
None

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions