Skip to content

Review use of DataFusion::Internal and ensure they are returned for bugs in DataFusion #6108

@alamb

Description

@alamb

Is your feature request related to a problem or challenge?

There are a variety of places where internal errors are raised in DataFusion:
https://github.com/search?q=repo%3Aapache%2Farrow-datafusion+DataFusionError%3A%3AInternal&type=code

End applications often translate internal errors into something different (aka hide details from the user as they can't do anything about it) rather than a Plan or Execution error (which signals an issue in the query)

Describe the solution you'd like

  1. Audit all the uses of DataFusionError::Internal errors and change any to DataFusion::Plan or DataFusion::Execution as appropriate
  2. Update the doc strings on DataFusionError to make it clear DataFusionError::Internal should be used only when there is a bug in DataFusion (rather than an error in the query)

Describe alternatives you've considered

No response

Additional context

https://github.com/influxdata/influxdb_iox/issues/7606

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions