implement short_circuits function for ScalarUDFImpl trait #10168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liukun4515
reviewed
Apr 22, 2024
| ) -> Result<ExprSimplifyResult> { | ||
| Ok(ExprSimplifyResult::Original(args)) | ||
| } | ||
| /// Returns true if some of this `exprs` subexpressions may not be evaluated |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Returns true if some of this `exprs` subexpressions may not be evaluated | |
| /// Returns true if some of this `exprs` subexpressions may not be evaluated |
Contributor
|
after #10098 merge, you can rewrite this function for |
Contributor
#10098 is merged now. Thank you @Lordworms |
alamb
approved these changes
Apr 22, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Lordworms . Looks great to me
cc @Omega359
ccciudatu
pushed a commit
to hstack/datafusion
that referenced
this pull request
Apr 26, 2024
* implement short_circuits function for ScalarUDFImpl trait * finish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10162
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?