Minor: Add Column::from(Tableref, &FieldRef), Expr::from(Column) and Expr::from(Tableref, &FieldRef)
#10178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
commented
Apr 22, 2024
| } | ||
|
|
||
| /// Create a column, use qualifier and field name | ||
| impl From<(Option<&TableReference>, &FieldRef)> for Column { |
Contributor
Author
There was a problem hiding this comment.
This is the new API -- the rest of this PR updates the code to use it when possible
comphead
reviewed
Apr 22, 2024
benchmarks/src/tpch/convert.rs
Outdated
| .map(|(qualifier, field)| { | ||
| Expr::Column(Column::from((qualifier, field.as_ref()))) | ||
| }) | ||
| .map(Column::from) |
Contributor
There was a problem hiding this comment.
can we still use a single map?
Contributor
Author
There was a problem hiding this comment.
Good call -- I added some more Expr::from impls in c4bc7e3 and now this looks pretty nice
alamb
changed the title
Column::from(Tableref, &FieldRef)Column::from(Tableref, &FieldRef), Expr::from(Column) and Expr::from(Tableref, &FieldRef)
alamb
commented
Apr 22, 2024
| .map(|(qualifier, field)| { | ||
| Expr::Column(Column::from((qualifier, field.as_ref()))) | ||
| }) | ||
| .map(Expr::from) |
Contributor
Author
There was a problem hiding this comment.
This is now pretty nice I think given @comphead 's suggestion ❤️
Contributor
Author
andygrove
approved these changes
Apr 22, 2024
haohuaijin
approved these changes
Apr 23, 2024
Contributor
haohuaijin
left a comment
haohuaijin
left a comment
There was a problem hiding this comment.
LGTM, thank you @alamb
Contributor
Author
|
Thanks everyone for the reviews ❤️ |
ccciudatu
pushed a commit
to hstack/datafusion
that referenced
this pull request
Apr 26, 2024
…and `Expr::from(Tableref, &FieldRef)` (apache#10178) * Minor: Add `Column::from(Tableref, &FieldRef)` * Add Expr::from() * fix docs * Fix doc test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #9595 from @haohuaijin
Rationale for this change
@appletreeisyellow and I noticed this while upgrading IOx -- there are times when the code would like to create
Expr::Columnthat reference each of the columns in a schemaTo do so it would be nice to be able to create a
Columndirectly from a&FieldRefrather than having to to first call.as_ref()on the `FieldRefWhat changes are included in this PR?
Changes:
Column::from(Tableref, &FieldRef)Expr::from(Column)Expr::from(Tableref, &FieldRef)Are these changes tested?
By existing tests
Are there any user-facing changes?