[MINOR] Remove ScalarFunction from datafusion.proto #10173 #10202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriibugakov
force-pushed
the
10173-remove-scalar-function
branch
from
779955f to
b7deb1d
Compare
Contributor
|
Thank you @dmitrybugakov |
alamb
approved these changes
Apr 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
A very nice first PR indeed ❤️ Thanks again!
Contributor
|
lgtm |
Contributor
|
Thanks again @dmitrybugakov |
liukun4515
reviewed
Apr 24, 2024
| NegativeNode negative = 13; | ||
| InListNode in_list = 14; | ||
| Wildcard wildcard = 15; | ||
| ScalarFunctionNode scalar_function = 16; |
Contributor
liukun4515
reviewed
Apr 24, 2024
| PhysicalSortExprNode sort = 10; | ||
| PhysicalNegativeNode negative = 11; | ||
| PhysicalInListNode in_list = 12; | ||
| PhysicalScalarFunctionNode scalar_function = 13; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10173
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?