Optimize EliminateFilter to avoid unnecessary copies #10288 #10302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omega359
reviewed
Apr 30, 2024
| fn rewrite( | ||
| &self, | ||
| plan: LogicalPlan, | ||
| _config: &dyn OptimizerConfig, |
Contributor
There was a problem hiding this comment.
I believe the code in this function uses this so it likely should not start with an underscore as that is a convention to indicate it's not used.
Contributor
Author
There was a problem hiding this comment.
@Omega359 clippy was failed with
Parameter config is only used in recursion. Consider prefixing it with an underscore: _config.
Contributor
There was a problem hiding this comment.
Ahh. My apologies, I didn't see that
dmitriibugakov
force-pushed
the
10288-optimize-eliminate-filter
branch
2 times, most recently
from
027dbc3 to
9e0664f
Compare
jonahgao
reviewed
Apr 30, 2024
| Some(false) | None => Ok(Transformed::yes(LogicalPlan::EmptyRelation( | ||
| EmptyRelation { | ||
| produce_one_row: false, | ||
| schema: unwrap_arc(input).schema().clone(), |
Member
There was a problem hiding this comment.
Suggested change
| schema: unwrap_arc(input).schema().clone(), | |
| schema: input.schema().clone(), |
Could we remove the unwrap_arc here?
dmitriibugakov
force-pushed
the
10288-optimize-eliminate-filter
branch
from
9e0664f to
4f893ee
Compare
alamb
approved these changes
Apr 30, 2024
| .. | ||
| }) => match v { | ||
| Some(true) => Ok(Transformed::yes( | ||
| self.rewrite(unwrap_arc(input), _config)?.data, |
Contributor
There was a problem hiding this comment.
I almost wonder if this recursion is even necessary given that it already does ApplyOrder::TopDown the optimizer itself will call Self::rewrite on the inputs
In other words, it might be possible to do
Suggested change
| self.rewrite(unwrap_arc(input), _config)?.data, | |
| unwrap_arc(input) |
dmitriibugakov
force-pushed
the
10288-optimize-eliminate-filter
branch
from
4f893ee to
507f1c5
Compare
alamb
approved these changes
Apr 30, 2024
| input, | ||
| .. | ||
| }) => match v { | ||
| Some(true) => Ok(Transformed::yes(unwrap_arc(input))), |
alamb
reviewed
Apr 30, 2024
| } | ||
|
|
||
| #[test] | ||
| fn eliminate_nested_filters() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10288.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?