Rename monotonicity as output_ordering in ScalarUDF's #10596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
approved these changes
May 21, 2024
Contributor
There was a problem hiding this comment.
Thank you @berkaysynnada -- this looks much nicer.
Note to other reviewers, while this is technically an API change, it hasn't been released yet so I am not going to mark this PR as breaking and avoid calling it out in the docs
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The signature and usage of the monotonicity API have significantly changed. Therefore, we believe that
output_ordering()better reflects the new approach. #10504 (comment)What changes are included in this PR?
This PR just renames the
monotonicity()methods asoutput_ordering()in bothScalarUDFandScalarUDFImpl.Are these changes tested?
Are there any user-facing changes?