Extract parquet statistics from f16 columns, add ScalarValue::Float16
#10763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lordworms
force-pushed
the
issue_10757
branch
3 times, most recently
from
a93557c to
7edf9c3
Compare
alamb
changed the title
ScalarValue::Float16
alamb
reviewed
Jun 2, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Lordworms -- other than the println I think this PR is ready to go
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
Author
|
seems like there is a CI/CD issue |
alamb
approved these changes
Jun 3, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Lordworms -- I took the liberty of merging up from main to resolve some conflicts in this PR
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…6` (apache#10763) * Extract parquet statistics from f16 columns * Update datafusion/common/src/scalar/mod.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10757
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?