Fix extract parquet statistics from Decimal256 columns #10777
Conversation
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @xinlifoobar -- again a really nice PR 🙏
| None, | ||
| Some(i256::from(22000)), | ||
| // row group 2 | ||
| Some(i256::MAX), |
|
I am slowly merging these PRs after resolving conflicts. I hope to be done by tomorrow |
Hey @alamb, because we are not in the same time zone, I couldn't resolve such issues on time. I will periodically check my PRs to resolve conflicts in my daytime and just feel free to leave a comment when you found one. Thanks in advance :) |
No worries at all -- thank @xinlifoobar -- there were about 5 PRs adding support for the different types that conflicted so Iw as just working through each PR one by one and resolving the conflicts myself. Otherwise as you pointed out, timezone differences mean it would likely take 5 days to get them all in I'll handle getting this one in (it is next on the list) |
|
Thanks @Weijun-H and @xinlifoobar |
* Fix Extract parquet statistics from Decimal256 columns * Fix comment --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
3 participants
Which issue does this PR close?
Closes #10755 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?