Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Oct 8, 2021

Which issue does this PR close?

Closes #1177

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist force-pushed the try-out-2021 branch 3 times, most recently from c5004a0 to 16b9482 Compare October 19, 2021 02:45
@jimexist jimexist marked this pull request as ready for review October 21, 2021 16:00
@jimexist jimexist changed the title use 2021 edition use 2021 edition in datafusion codebase Oct 23, 2021
@alamb
Copy link
Contributor

alamb commented Oct 26, 2021

@jimexist would you like any help pushing this PR through?

@jimexist jimexist force-pushed the try-out-2021 branch 3 times, most recently from 100f877 to e2ee3ff Compare October 27, 2021 01:57
@jimexist jimexist requested review from Dandandan, alamb, andygrove and houqp and removed request for andygrove October 27, 2021 03:36
@jimexist
Copy link
Member Author

@alamb i have fixed the issue preventing the tests from running, this pull request is now ready

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me -- thanks @jimexist !

@alamb alamb merged commit b020aba into apache:master Oct 27, 2021
@jimexist jimexist deleted the try-out-2021 branch October 27, 2021 23:36
@houqp houqp added the development-process Related to development process of DataFusion label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we have plan to upgrade to Rust 2021 edition?

3 participants