Merged
Conversation
github-actions
bot
added
logical-expr
Member
Author
|
@jayzhan211 Mind taking a quick look? I'm a new contributor, so I might miss something. |
pingsutw
changed the title
jayzhan211
approved these changes
Jun 23, 2024
Contributor
jayzhan211
left a comment
jayzhan211
left a comment
There was a problem hiding this comment.
It looks pretty nice!
alamb
approved these changes
Jun 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @pingsutw and @jayzhan211 for the review
I took the liberty of merging this branch up from main to resolve some conflicts
Contributor
Member
Author
|
Thank you all! |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* init Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * remove files Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10884
Rationale for this change
We are moving aggregate functions out of the core to ensure the core APIs are sufficient to implement all aggregates and make datafusion more configurable
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?