Support filter for List#11091
Merged
jayzhan211 merged 5 commits intoapache:mainfrom Jun 27, 2024
Merged
Conversation
github-actions
Bot
added
physical-expr
Contributor
Author
|
It seems we need to rewrite The purpose is to remove these two lines, which tries to convert non-list to list, which is not expected. But it is incorrectly used for datafusion/datafusion/expr/src/type_coercion/binary.rs Lines 957 to 958 in c7ac8b8 |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
alamb
approved these changes
Jun 26, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jayzhan211 -- this looks very good to me 👨🍳 👌
Really nice
| return Ok(BooleanArray::new_null(len)); | ||
| } | ||
|
|
||
| let cmp = make_comparator(l, r, SortOptions::default())?; |
Contributor
There was a problem hiding this comment.
is it worth a comment here explaining the choice of NULL comparison / sorting?
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Contributor
|
🚀 |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* support basic list cmp Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add more ops Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add distinct Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * nested Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add comment Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #9857
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?