add python binding for approx_distinct aggregate function
#1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
force-pushed
the
add-approx-distinct-python-fun
branch
from
db84377 to
f288184
Compare
Member
|
the diff seems to include changes from the lit fix pr. EDIT: never mind, you already mentioned this in the PR description :D |
jimexist
force-pushed
the
add-approx-distinct-python-fun
branch
from
68f6563 to
2216ce0
Compare
jimexist
force-pushed
the
add-approx-distinct-python-fun
branch
from
2216ce0 to
4f11051
Compare
houqp
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
add python binding for
approx_distinctaggregate functionCloses #1133
Code based on #1130 so review that first
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?