Support alternate formats for unparsing datetime to timestamp and interval#11466
Merged
alamb merged 8 commits intoapache:mainfrom Jul 16, 2024
Merged
Conversation
* use timestamp as the identifier for date64 * rename * implement CustomDialectBuilder * fix
--------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
changed the title
datetime to timestamp and interval
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
… `interval` (apache#11466) * Unparser rule for datatime cast (apache#10) * use timestamp as the identifier for date64 * rename * implement CustomDialectBuilder * fix * dialect with interval style (apache#11) --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * fmt * clippy * doc * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * update the doc for CustomDialectBuilder * fix doc test --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
… `interval` (apache#11466) * Unparser rule for datatime cast (apache#10) * use timestamp as the identifier for date64 * rename * implement CustomDialectBuilder * fix * dialect with interval style (apache#11) --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * fmt * clippy * doc * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * update the doc for CustomDialectBuilder * fix doc test --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
… `interval` (apache#11466) * Unparser rule for datatime cast (#10) * use timestamp as the identifier for date64 * rename * implement CustomDialectBuilder * fix * dialect with interval style (#11) --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * fmt * clippy * doc * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * update the doc for CustomDialectBuilder * fix doc test --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR address more dialect variety in unparser:
Rationale for this change
SQLStandard format interval is needed for dbms like dremio.
datetimeis missing for certain dbms too: dremio, trino.What changes are included in this PR?
See "What issue does this PR close"
Are these changes tested?
Yes, unit tests added
Are there any user-facing changes?
n/a. But changed one
CustomDialect::newto be deprecated in favor ofCustomDialectBuilder