Test + workaround for SanityCheckPlan error
#11493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Jul 16, 2024
| 11)------PlaceholderRowExec | ||
|
|
||
|
|
||
| ### |
Contributor
Author
There was a problem hiding this comment.
Without the code in this PR these tests fail like this:
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ cargo test --test sqllogictests -- union
Compiling datafusion v40.0.0 (/Users/andrewlamb/Software/datafusion2/datafusion/core)
Compiling datafusion-sqllogictest v40.0.0 (/Users/andrewlamb/Software/datafusion2/datafusion/sqllogictest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 6.10s
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-6e33fb5db6770e8f)
Running "pg_compat/pg_compat_union.slt"
Running "union.slt"
External error: query failed: DataFusion error: SanityCheckPlan
caused by
Error during planning: Child: ["UnionExec", " SortExec: expr=[a@0 ASC NULLS LAST], preserve_partitioning=[true]", " ProjectionExec: expr=[CAST(a@0 AS Utf8) as a]", " RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1", " CsvExec: file_groups={1 group: [[Users/andrewlamb/Software/datafusion2/datafusion/core/tests/data/example.csv]]}, projection=[a], output_ordering=[a@0 ASC NULLS LAST], has_header=true", " ProjectionExec: expr=[bar as a]", " CsvExec: file_groups={1 group: [[Users/andrewlamb/Software/datafusion2/datafusion/core/tests/data/example.csv]]}, has_header=true"] does not satisfy parent order requirements: [PhysicalSortRequirement { expr: Column { name: "a", index: 0 }, options: Some(SortOptions { descending: false, nulls_first: false }) }]
[SQL] SELECT (SELECT a from t ORDER BY a) UNION ALL (SELECT 'bar' as a from t) ORDER BY a;
at test_files/union.slt:629
alamb
commented
Jul 16, 2024
| if child.as_any().downcast_ref::<UnionExec>().is_some() { | ||
| continue; | ||
| } | ||
| if child.as_any().downcast_ref::<SortExec>().is_some() { |
Contributor
Author
There was a problem hiding this comment.
Locally i had to disable checking for SortExec as well to get our tests passing
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a workaround + some tests for #11492
I don't think this should be merged, I am just posting it here so:
Rationale for this change
See #11492
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?