Update SPLIT_PART scalar function to support Utf8View #11975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
Contributor
Author
|
an unrelated ci fail |
alamb
approved these changes
Aug 15, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @Lordworms -- I left some suggestions but I also think this PR could be merged in as is. Love to see the code 🚋 carrying on
| Ok(Some(split_string[index])) | ||
| } else { | ||
| Ok(Some("")) | ||
| match (args[0].data_type(), args[1].data_type()) { |
Contributor
There was a problem hiding this comment.
split_part is one of the functions where we could actually use StringViewArray to speed up its implementation (by avoiding a string copy). This function as written will copy the parts along
It might be a fun optimization project to try as a follow on
| } | ||
| } | ||
|
|
||
| macro_rules! process_split_part { |
Contributor
Contributor
|
Thanks again @Lordworms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11950
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?