Skip to content

Handle arguments checking of min/max function to avoid crashes #12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Aug 15, 2024
Merged

Handle arguments checking of min/max function to avoid crashes #12016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e54dca
Handle arguments checking of min/max function to avoid crashes
tlm365 Aug 15, 2024
ec919d8
Fix code format error
tlm365 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions datafusion/functions-aggregate/src/min_max.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ use arrow::datatypes::{
Int32Type, Int64Type, Int8Type, UInt16Type, UInt32Type, UInt64Type, UInt8Type,
};
use arrow_schema::IntervalUnit;
use datafusion_common::{downcast_value, internal_err, DataFusionError, Result};
use datafusion_common::{
downcast_value, exec_err, internal_err, DataFusionError, Result,
};
use datafusion_functions_aggregate_common::aggregate::groups_accumulator::prim_op::PrimitiveGroupsAccumulator;
use std::fmt::Debug;

Expand All @@ -68,7 +70,12 @@ use std::ops::Deref;

fn get_min_max_result_type(input_types: &[DataType]) -> Result<Vec<DataType>> {
// make sure that the input types only has one element.
assert_eq!(input_types.len(), 1);
if input_types.len() != 1 {
return exec_err!(
"min/max was called with {} arguments. It requires only 1.",
input_types.len()
);
}
// min and max support the dictionary data type
// unpack the dictionary to get the value
match &input_types[0] {
Expand Down